From 8b9c50b0fee3b989c384e78cfe69a8f3d12b3a21 Mon Sep 17 00:00:00 2001
From: pengzhanbo <volodymyr@foxmail.com>
Date: Tue, 21 Jan 2025 11:59:15 +0800
Subject: [PATCH] perf(theme): improve bulletin `enablePage` (#438)

---
 theme/src/node/pages/pageBulletin.ts | 30 ++++++++++------------------
 1 file changed, 11 insertions(+), 19 deletions(-)

diff --git a/theme/src/node/pages/pageBulletin.ts b/theme/src/node/pages/pageBulletin.ts
index db57e925..c46c2cca 100644
--- a/theme/src/node/pages/pageBulletin.ts
+++ b/theme/src/node/pages/pageBulletin.ts
@@ -1,29 +1,21 @@
 import type { Page } from 'vuepress/core'
-import type { BulletinOptions, PlumeThemeLocaleOptions, PlumeThemePageData } from '../../shared/index.js'
-import { isPlainObject } from '@vuepress/helper'
+import type { PlumeThemeLocaleOptions, PlumeThemePageData } from '../../shared/index.js'
+import { isFunction, isPlainObject } from '@vuepress/helper'
 
 export function enableBulletin(
   page: Page<PlumeThemePageData>,
   options: PlumeThemeLocaleOptions,
 ) {
-  let enablePage: BulletinOptions['enablePage']
-  if (isPlainObject(options.bulletin) && options.bulletin.enablePage) {
-    enablePage = options.bulletin.enablePage
+  if (isPlainObject(options.bulletin)) {
+    const enablePage = options.bulletin.enablePage
+    page.data.bulletin = (isFunction(enablePage) ? enablePage(page) : enablePage) ?? true
   }
-  else if (options.locales) {
-    for (const locale of Object.keys(options.locales)) {
-      if (isPlainObject(options.locales[locale].bulletin) && options.locales[locale].bulletin.enablePage) {
-        enablePage = options.locales[locale].bulletin.enablePage
-        break
-      }
+
+  if (options.locales?.[page.pathLocale]) {
+    const bulletin = options.locales?.[page.pathLocale].bulletin
+    if (isPlainObject(bulletin)) {
+      const enablePage = bulletin.enablePage
+      page.data.bulletin = (isFunction(enablePage) ? enablePage(page) : enablePage) ?? true
     }
   }
-
-  if (typeof enablePage === 'function') {
-    page.data.bulletin = enablePage(page) ?? true
-  }
-
-  else {
-    page.data.bulletin = enablePage ?? !!options.bulletin
-  }
 }