From 560eef0a48dfd20b26b9020a639abfb5bd727950 Mon Sep 17 00:00:00 2001
From: pengzhanbo <volodymyr@foxmail.com>
Date: Mon, 7 Apr 2025 07:38:34 +0800
Subject: [PATCH] refactor(theme): add transition for navScreen (#548)

---
 .../components/Nav/VPNavScreenMenuGroup.vue   | 47 +++++++++----------
 .../Nav/VPNavScreenTranslations.vue           | 27 ++++++-----
 2 files changed, 37 insertions(+), 37 deletions(-)

diff --git a/theme/src/client/components/Nav/VPNavScreenMenuGroup.vue b/theme/src/client/components/Nav/VPNavScreenMenuGroup.vue
index eed0824d..14892d2a 100644
--- a/theme/src/client/components/Nav/VPNavScreenMenuGroup.vue
+++ b/theme/src/client/components/Nav/VPNavScreenMenuGroup.vue
@@ -3,8 +3,11 @@ import type { ThemeIcon } from '../../../shared/index.js'
 import VPNavScreenMenuGroupLink from '@theme/Nav/VPNavScreenMenuGroupLink.vue'
 import VPNavScreenMenuGroupSection from '@theme/Nav/VPNavScreenMenuGroupSection.vue'
 import VPIcon from '@theme/VPIcon.vue'
+import { FadeInExpandTransition } from '@vuepress/helper/client'
 import { computed, ref } from 'vue'
 
+import '@vuepress/helper/transition/fade-in-height-expand.css'
+
 const props = defineProps<{
   text: string
   icon?: ThemeIcon
@@ -37,42 +40,37 @@ function toggle() {
       <span class="vpi-plus button-icon" />
     </button>
 
-    <div :id="groupId" class="items">
-      <template v-for="item in items" :key="item.text">
-        <div v-if="'link' in item" :key="item.text" class="item">
-          <VPNavScreenMenuGroupLink :item="item" />
-        </div>
+    <FadeInExpandTransition>
+      <div v-show="isOpen" :id="groupId" class="vp-nav-screen-menu-group-container">
+        <div class="items">
+          <template v-for="item in items" :key="item.text">
+            <div v-if="'link' in item" :key="item.text" class="item">
+              <VPNavScreenMenuGroupLink :item="item" />
+            </div>
 
-        <div v-else class="group">
-          <VPNavScreenMenuGroupSection
-            :text="item.text"
-            :items="item.items"
-            :icon="item.icon"
-          />
+            <div v-else class="group">
+              <VPNavScreenMenuGroupSection
+                :text="item.text"
+                :items="item.items"
+                :icon="item.icon"
+              />
+            </div>
+          </template>
         </div>
-      </template>
-    </div>
+      </div>
+    </FadeInExpandTransition>
   </div>
 </template>
 
 <style scoped>
 .vp-nav-screen-menu-group {
-  height: 48px;
-  overflow: hidden;
+  min-height: 48px;
   border-bottom: 1px solid var(--vp-c-divider);
   transition: border-color var(--vp-t-color);
 }
 
 .vp-nav-screen-menu-group .items {
-  visibility: hidden;
-}
-
-.vp-nav-screen-menu-group.open .items {
-  visibility: visible;
-}
-
-.vp-nav-screen-menu-group.open {
-  height: auto;
+  padding-top: 6px;
   padding-bottom: 10px;
 }
 
@@ -94,7 +92,6 @@ function toggle() {
 }
 
 .vp-nav-screen-menu-group.open .button {
-  padding-bottom: 6px;
   color: var(--vp-c-brand-1);
 }
 
diff --git a/theme/src/client/components/Nav/VPNavScreenTranslations.vue b/theme/src/client/components/Nav/VPNavScreenTranslations.vue
index a152bae1..5888ade4 100644
--- a/theme/src/client/components/Nav/VPNavScreenTranslations.vue
+++ b/theme/src/client/components/Nav/VPNavScreenTranslations.vue
@@ -1,8 +1,11 @@
 <script setup lang="ts">
 import VPLink from '@theme/VPLink.vue'
+import { FadeInExpandTransition } from '@vuepress/helper/client'
 import { ref } from 'vue'
 import { useLangs } from '../../composables/index.js'
 
+import '@vuepress/helper/transition/fade-in-height-expand.css'
+
 const { localeLinks, currentLang } = useLangs()
 const isOpen = ref(false)
 
@@ -23,26 +26,26 @@ function toggle() {
       <span class="vpi-chevron-down icon chevron" />
     </button>
 
-    <ul class="list">
-      <li v-for="locale in localeLinks" :key="locale.link" class="item">
-        <VPLink class="link" :href="locale.link">
-          {{ locale.text }}
-        </VPLink>
-      </li>
-    </ul>
+    <FadeInExpandTransition>
+      <div v-show="isOpen" class="vp-nav-screen-translations-container">
+        <ul class="list">
+          <li v-for="locale in localeLinks" :key="locale.link" class="item">
+            <VPLink class="link" :href="locale.link">
+              {{ locale.text }}
+            </VPLink>
+          </li>
+        </ul>
+      </div>
+    </FadeInExpandTransition>
   </div>
 </template>
 
 <style lang="scss" scoped>
 .vp-nav-screen-translations {
-  height: 24px;
+  min-height: 24px;
   overflow: hidden;
 }
 
-.vp-nav-screen-translations.open {
-  height: auto;
-}
-
 .title {
   display: flex;
   align-items: center;